Re: Insert-Symbol-Enhancement

On Tue, 2007-03-27 at 21:01 +0200, Michael Rosenbruch wrote:
> Hi Marc
> >> Had a very quick look; the api change will undoubtedly break other
> >> platforms, but should not be too hard to fix to get it to build.
> >>
> >> I think there is a bug in the @@ -2083,7 +2092,7 @@ hunk, where after
> >> the loop iOffset += k is needed (there is even worse bug in the original
> >> though, which looks like an endless loop to me).
> >
> > Michael, could you look at this comment as well to see if it is valid?
> > If so, I'd like to commit it soonish, as it's a really nice improvement.
> >
> Hi I looked into that and I found, that I missed the point there, I
> corrected that but I am unable to test that piece of code because it
> seems nowhere used anymore...
> So if somebody knows how to test that I would appreciate that.

Thanks a lot! I committed your patch, so it will be in the 2.5.2
release.

Marc

PS. Platform maintainers: could you check that this doesn't break
anything? I think it won't, but please test.
Received on Tue Apr 3 14:56:03 2007