Re: [Fwd: CVS: commit msevior abi/src/af/xap/unix xap_UnixFrameImpl.cpp]

On Mon, 2007-04-23 at 00:49 +1000, msevior@physics.unimelb.edu.au wrote:
> Win32 and OSX maintainers. Please note this commit will break your builds.
> You need to define xap_FrameImpl::_setPresentation(bool)

Don't want to whine, but no plugin specific name calling in abiword-core
please!

I'd suggest calling it "_showScrollbar(bool visible)" or something (or
something else, depending on what it does).

Marc

> Cheers
>
> Martin
>
>
> ---------------------------- Original Message ----------------------------
> Subject: CVS: commit msevior abi/src/af/xap/unix xap_UnixFrameImpl.cpp
> From: cvs@abisource.com
> Date: Mon, April 23, 2007 00:44
> To: abisource-cvs-commit@abisource.com
> --------------------------------------------------------------------------
>
>
> Update of /cvsroot/abi/src/af/xap/unix
> In directory abiword.snt.utwente.nl:/tmp/cvs-serv26754/src/af/xap/unix
>
> Modified Files:
> xap_UnixFrameImpl.cpp
> Log Message:
>
> Hide menu and attempt to hide vertical scroolbar. This commit will break
> windows and OSX builds because the method virtual void
> Xap_FrameImpl::_setPresentation(bool bPresentation) = 0 needs to be
> defined for thos platforms. This method should hide the menu bar and the
> vertical scroll bar.
>
>
> Index: xap_UnixFrameImpl.cpp
> ===================================================================
> RCS file: /cvsroot/abi/src/af/xap/unix/xap_UnixFrameImpl.cpp,v
> retrieving revision 1.147
> retrieving revision 1.148
> diff -u -d -r1.147 -r1.148
> --- xap_UnixFrameImpl.cpp 2 Apr 2007 13:20:06 -0000 1.147
> +++ xap_UnixFrameImpl.cpp 22 Apr 2007 14:44:33 -0000 1.148
> @@ -1988,7 +1988,6 @@
> return m_pUnixMenu;
> }
>
> -
> void XAP_UnixFrameImpl::_setFullScreen(bool changeToFullScreen)
> {
> if (!GTK_IS_WINDOW(m_wTopLevelWindow)) return;
>
> -----------------------------------------------
> To unsubscribe from this list, send a message to
> abisource-cvs-commit-request@abisource.com with the word
> unsubscribe in the message body.
>
>
Received on Sun Apr 22 17:15:37 2007