Re: CVS: commit msevior abi/src/af/gr/unix gr_UnixPangoGraphics.cpp gr_UnixPangoGraphics.h

msevior@physics.unimelb.edu.au wrote:
>>> --- gr_UnixPangoGraphics.h 29 Dec 2006 21:09:28 -0000 1.35
>>> +++ gr_UnixPangoGraphics.h 1 Jan 2007 10:54:09 -0000 1.36
>>> @@ -460,7 +460,10 @@
>>> virtual UT_uint32 getFontAscent(GR_Font *);
>>> virtual UT_uint32 getFontDescent(GR_Font *);
>>> virtual UT_uint32 getFontHeight(GR_Font *);
>>> -
>>> + double getResolutionRatio(void)
>>> + {
>>> + return m_dResRatio;
>>> + }
>> Martin, why was this public method added ?
>>
>
> Hi Tomas,
> I needed this to get glyphBox to calculate the correct size font.
> It makes AbiMAthView print correctly.
>

Sorry, I should have been more specific. This should not be a *public*
method as it is exposing something about the implementation details of
the class that are nobody's business; it should be private (or at most
protected).

Tomas
Received on Wed Jan 3 11:06:24 2007