Re: CVS: commit tomas_f abi/src/wp/ap/unix GNUmakefile.am ap_UnixApp.cpp ap_UnixDialog_All.h

On 1/12/07, cvs@abisource.com <cvs@abisource.com> wrote:

[...]

> -libWpAp_unix_a_SOURCES=\
> +if WITH_SPELL
> +spellsrc= ap_@ABI_FE@Dialog_Spell.cpp
> +endif

Here's another nitpick: please do no more use the @ABI_FE@ macro for
source file names. In a GNUmakefile.am's directory the name of a
source file is always known and never platform-dependent as platform
sources are always separated into different directories.

E.g.: when running 'make dist' on linux, ABI_FE is set to "Unix".
Therefore trying to dist the file ap_Win32Dialog_Spell.cpp, referred
to as ap_@ABI_FE@Dialog_Spell.cpp in GNUmakefile.am will fail. Same
for "Cocoa".

Cheers,
Rob
Received on Mon Jan 15 16:04:32 2007