Re: CVS: commit robsta abi/src/text/fmt/xp fv_View.h fv_VisualDragText.h

On Tue, 2007-01-23 at 20:25 +0000, Tomas Frydrych wrote:
> Hi Rob,
>
> > class FL_DocLayout;
> > @@ -978,7 +983,11 @@
> > fv_PropCache m_SecProps;
> > AV_ListenerId m_CaretListID;
> > FV_FrameEdit m_FrameEdit;
> > +#ifdef XP_UNIX_TARGET_GTK
> > + FV_UnixVisualDrag m_VisualDragText;
> > +#else
> > FV_VisualDragText m_VisualDragText;
> > +#endif
>
> Why is this necessary? I assume there are good reasons for this, but I
> am very uneasy about introducing platform specific code into src/text,
> and particularly src/text/fmt, so I would like to know bit more about
> these changes. Thanks.

It breaks plugin building as well:

In file included from AbiCollabSessionManager.cpp:27:
../../../../abi/src/text/fmt/xp/fv_View.h:46:31: error:
fv_UnixVisualDrag.h: No such file or directory
../../../../abi/src/text/fmt/xp/fv_View.h:431: error: ISO C++ forbids
declaration of 'FV_VisualDragText' with no type
../../../../abi/src/text/fmt/xp/fv_View.h:431: error: expected ';'
before '*' token
../../../../abi/src/text/fmt/xp/fv_View.h:438: error: expected `;'
before 'void'
../../../../abi/src/text/fmt/xp/fv_View.h:990: error:
'FV_UnixVisualDrag' does not name a type

Marc
Received on Tue Jan 23 22:52:39 2007