Re: jordimas - r21586 - in abiword/trunk/src: af/xap/xp wp/ap/win

From: Jordi Mas <jmas_at_softcatala.org>
Date: Wed Jul 11 2007 - 17:22:12 CEST

En/na J.M. Maurer ha escrit:
> On Wed, 2007-07-11 at 08:54 +0200, cvs@abisource.com wrote:
>> Fixes Ryan Pavlik problem regarding AbiCollab dialog boxes. I'm
>> overriting the previous patch since I belive mine is more elaborate.
>
> Erm, RP's version was always correct; Yours is only correct if someone
> doesn't screw up the dialog ordering. How is that better?

There is piece of code in DEBUG mode that makes sure that order is right, if
it is not it does fires an ASSERT. That prevents the problem from happing
again. In my version, I do not need to compare as many times and as elements
are in release mode to find out the next element. I prefer to make an effort
that to waste user's CPU cycles.

Jordi,

-- 
Jordi Mas i Hernāndez, HomePage http://www.softcatala.org/~jmas/
Bloc personal http://www.softcatala.org/~jmas/bloc/
Planeta Softcatalā: http://www.softcatala.org/planet/
Received on Wed Jul 11 17:21:05 2007

This archive was generated by hypermail 2.1.8 : Wed Jul 11 2007 - 17:21:05 CEST