Re: My first patch

I can tell. So what can we do? We can:

1) Only make the dialog portable. This is easy: we just change the
s_AskCloseAllAndExit() function in ap_EditMethods.cpp. What I don't
know is how to use the same function on more than one OS, so that
everything but Mac OS X has the current.
2) Make everything platform-dependent so we can use whatever HIG the
OS provides. The issue is for Linux platforms that use non-GNOME
desktops.
3) Make the Apple HIG the default on all systems. This breaks all
other HIGs, if there are such.
4) Forget the Apple HIG and use the portable version. This is the
easiest option, but I don't know what Apple will say.

On Jun 18, 2007, at 10:30 PM, Hubert Figuiere wrote:

>
> Pietro Gagliardi wrote:
>> Someone once added a feature which asked whether or not you wanted to
>> review changes or not. However, a set of #if clauses prevented
>> this from
>> being run, and thus the bug report. I removed the #if statements,
>> thus
>> fixing the bug.
>
> This was disabled on MacOS X for some reason. Now that I'm re-read the
> HIG, I reenabled it, but no like you did (we did discuss than on IRC).
> It is not exactly accurate, but it is closer. Making it more
> conformant
> to the MacOS X HIG is actually a much deeper change.
>
>
> Hub
Received on Tue Jun 19 20:43:52 2007