Re: uwog - r21506 - abiword-plugins/trunk/tools/abicollab/core/session/xp

On Wed, 2007-06-27 at 18:07 -0400, Hubert Figuiere wrote:
> > --- abiword-plugins/trunk/tools/abicollab/core/session/xp/AbiCollab_Import.h 2007-06-27 00:22:40 UTC (rev 21505)
> > +++ abiword-plugins/trunk/tools/abicollab/core/session/xp/AbiCollab_Import.h 2007-06-27 21:19:56 UTC (rev 21506)
> > @@ -22,6 +22,8 @@
> > #ifndef ABI_COLLAB_IMPORT_H
> > #define ABI_COLLAB_IMPORT_H
> >
> > +#include <vector>
> > +
> > #include "ut_types.h"
> > #include "pt_Types.h"
> > #include "px_ChangeRecord.h"
> > @@ -33,6 +35,8 @@
> > #include <AbiCollab_Export.h>
> > #include <xp/AbiCollab_Packet.h>
> >
> > +using std::vector;
> > +
>
>
> "using" clauses in header files are very dangerous and MUST be avoided.

Why ? I've been doing it for 5+ years now, and never had any problem.
It's not like we have our own "vector" class somewhere. And even then
the compiler would complain.

Marc
Received on Thu Jun 28 21:02:12 2007