Re: Insert-Symbol-Enhancement

J.M. Maurer wrote:
> On Mon, 2007-03-26 at 16:02 +0200, Michael Rosenbruch wrote:
>> Hi,
>> this patch enhance the gtk-insert-symbol-dialog.
>> Here is the list of the new features:
>> - shows all characters of a font (scrollbar)
>> - resize correct
>> - don't crash if you try to insert a non existing character.
>>
>> I need such a version of insert-symbol (not the gucharmap) because some
>> dingsbats-fonts are not usable with gucharmap. Gucharmap had other
>> issues, that if you select a character not in the chosen font you get
>> wired things.
>>
>> This patch may break some non unix-builds, but I have not tested that.
>
> Didn't look at the actual code yet, but this does solve the crash I have
> when I open the Insert Symbol dialog, and it generally seems to work
> nicely.
>
> Tomas: this touches the character measuring, would you care to comment
> on those parts?

Had a very quick look; the api change will undoubtedly break other
platforms, but should not be too hard to fix to get it to build.

I think there is a bug in the @@ -2083,7 +2092,7 @@ hunk, where after
the loop iOffset += k is needed (there is even worse bug in the original
though, which looks like an endless loop to me).

Tomas
Received on Mon Mar 26 17:12:35 2007