Re: Platform code in XP code

This and the synchronizer.* in TCP backend are the only IFDEF's like
this that could be re-done in a better way, I think. The ideal design
solution for the TCP backend is to subclass the synchronizer on each
platform, I think. Given that here we only have two calls being
ifdef'ed (both in constructor-like situations), I am not sure what the
best way to clean this up is. IIRC, this is a testing file only, correct?

For the time being, is there a GTK define I can change this to so that
we don't have "ifndef WIN32" as a "cheating" way of saying "ifdef LINUXISH"?

Ryan

Hubert Figuiere wrote:
> Hi,
>
> I have to seriously disagree with this way of doing the platform code.
>
> #ifdef is not the right way.
>
> Hub
>
>
>> Fix AbiCollab build on Windows. That was easier than I expected!
>>
>> Modified: abiword-plugins/trunk/tools/abicollab/core/session/xp/AbiCollab_Command.cpp
>> ===================================================================
>> --- abiword-plugins/trunk/tools/abicollab/core/session/xp/AbiCollab_Command.cpp 2007-11-01 00:06:25 UTC (rev 22271)
>> +++ abiword-plugins/trunk/tools/abicollab/core/session/xp/AbiCollab_Command.cpp 2007-11-01 03:42:08 UTC (rev 22272)
>> @@ -29,9 +29,15 @@
>> #include "xap_App.h"
>> #include "xap_Frame.h"
>>
>> +#ifndef WIN32
>> #include "ap_UnixApp.h"
>> //#include "gr_UnixNullGraphics.h"
>> #include "ap_UnixFrame.h"
>> +
>> +#else
>> +// any windows stuff needed here?
>> +
>> +#endif
>> #include "gr_DrawArgs.h"
>>
>> #ifdef ABICOLLAB_HANDLER_FAKE
>> @@ -46,7 +52,12 @@
>> : m_argv(argv)
>> {
>> XAP_App* pApp = XAP_App::getApp ();
>> +
>> + #ifndef WIN32
>> pApp->getGraphicsFactory()->registerAsDefault(GRID_UNIX_NULL, true);
>> + #else
>> + pApp->getGraphicsFactory()->registerAsDefault(GRID_WIN32_UNISCRIBE, true);
>> + #endif
>> }
>>
>>
>>
>> -----------------------------------------------
>> To unsubscribe from this list, send a message to
>> abisource-cvs-commit-request@abisource.com with the word
>> unsubscribe in the message body.
>>
>
>
>

-- 
Ryan Pavlik
AbiWord Win32 Platform Maintainer, Art Lead: www.abisource.com
AbiWord Community Outreach Project: www.cleardefinition.com/oss/abi/blog/
"Optimism is the father that leads to achievement."
 -- Helen Keller
"The folder structure in a modern Linux distribution such as Ubuntu
was largely inspired by the original UNIX foundations that were
created by men with large beards and sensible jumpers."
 -- Jono Bacon, The Ubuntu Guide