Patch review requested - fix maemo build for pre-4.0

Hey everybody! Those of you on the bugzilla spam list have probably
guessed that I've been beta testing AbiWord builds on Chinook (Maemo
4.0, for Nokia Internet Tablets with OS2008). I recently sat down and
took the time to put together a patch to allow building on Bora (Maemo
3.x, for 2007) and in theory 2006 as well, I think. While I know that
the patch works (since it now builds correctly in both environments),
I'd like someone to take a look at it before I commit it, as I know that
working code doesn't necessarily mean good code. It's more or less
trivial - the problem it solves is that locations of headers moved
between pre-4.0 and 4.0 Maemo environments. I made the patch by looking
at the code changed by the 4.0 patch (thus knowing which includes were
updated), then finding the location of those headers in the previous SDK.

The bug is http://bugzilla.abisource.com/show_bug.cgi?id=11403 and the
patch is here, pretty small actually:
http://bugzilla.abisource.com/attachment.cgi?id=4444&action=view

It's against the 2.6 tree - a similar change will have to be made in
trunk but due to the build system changes there I decided to wait on
that and possibly give Rob a chance to look at it first, since the .m4
change will probably be entirely different.

Thanks!

Ryan
Received on Sat Feb 2 15:47:11 2008