Re: Smart quotes patch

Hi Bobby,

On Feb 5, 2008 5:04 PM, Bobby Weinmann <bobby.weinmann@gmail.com> wrote:
>
> Sorry - I originally replied just to Tomas.
>
> I did not test undo/redo. I didn't know about it, but I can take a
> look. While I am a developer, I am a complete newbie to the Abiword
> codebase.
>
> If, in theory, the developers are not averse to supporting smart
> quotes, I will work on it.

Please do so! Smart quotes are actually one of the most requested features.

> I don't know how much I can do for localization, since I don't know
> their rules. I don't know why that would be a problem for English
> support? The GUI I provided allows you to turn it off, so you'd have
> the same functionality as it exists today. This could even be the
> default, but at least English users _could_ have smart quotes.
>
> Smart quotes are implemented in terms of a function
> considerSmartQuoteCandidateAt() which could be overridden by different
> languages to provide their own rules. I will, time permitting, google
> the rules for the languages I can at least recognize: Hebrew, French,
> Spanish, German and Arabic. If I can't support all languages, are you
> not interested in any?

I think it is a reasonable approach to start with a small initial set
of supported languages.

> In closing, I'd just like to say that I have long been impressed with
> Abiword. It was the first Linux Word Processor I could type Hebrew
> in.

Thanks for giving back.
- Rob
Received on Wed Feb 6 00:53:23 2008