Re: rp - r24297 - abiword/branches/gsoc2008styles/src/text/ptbl/xp

From: Ryan Pavlik <abiryan_at_ryand.net>
Date: Thu Jun 26 2008 - 20:13:01 CEST

Hubert Figuiere wrote:
> On Thu, 2008-06-26 at 06:07 +0200, cvs@abisource.com wrote:
>
>> + getAllProperties ( (UT_Vector *) &vTheseProps, (UT_sint32) 0);
>> + getBasedOn()-> getAllProperties( (UT_Vector *) &vBasedOnProps,
>> (UT_sint32) 1);
>>
>
> Please don't do that kind of cast. IT IS VERY BAD! It is just breaking
> the type safety if not doing WORSE.
>
> Better fix getAllProperties() to use the proper vector type, but then it
> might be opening a can of worm.
>
>
> Hub
>
>
>
OK - This bit was confusing me, I was pleased just to get it to compile
:-/. I will see if I can change the getAllProperties without breaking
things.

(What would be the "proper" way to do this? Declare those variables as
UT_Vectors?)

Ryan

-- 
Ryan Pavlik
www.cleardefinition.com
#282  +  (442) -  [X]
A programmer started to cuss
Because getting to sleep was a fuss
As he lay there in bed
Looping 'round in his head
was: while(!asleep()) sheep++;
Received on Thu Jun 26 20:18:47 2008

This archive was generated by hypermail 2.1.8 : Thu Jun 26 2008 - 20:18:47 CEST