Re: Fwd: Smart quotes patch - committed.

1) The Smart Quotes tab in the preferences will either be added to or
removed (and the checkbox placed on another dialog).
2) The Smart Quotes preferences - whatever form they're in - need to
be added to the non-GTK+ platforms. I could do Windows, but it would
be better if someone else could. I don't have a Visual Studio setup
at home, and I just started a new job, so I'm wary of doing it at
work. Cocoa (or whatever else Abiword supports) is beyond me.
3) I believe that the default should be the predominant style of the
current locale, but that it should be easily changeable. Both because
of the multistyle locale and because of things like extended foreign
quotes, i.e. a couple paragraphs of French - quoted with guillemets -
in an English document. I think this is attainable with an extra
drop-down box on the Smart Quotes pref screen. Martin is right that
there really are only a couple of combinations.

I will try to come up with something as soon as I can. If someone has
a better idea, by all means, submit it (preferably via a patch).

Bobby

On Mon, Mar 17, 2008 at 5:40 AM, Dominic Lachowicz
<domlachowicz@gmail.com> wrote:
>
> Thanks, Tomas.My only remaining nit is that it takes up its own page
> in the preferences dialog. But that's not something to stop it from
> going into 2.6.
>
> -Dom
>
>
>
> On Mon, Mar 17, 2008 at 8:36 AM, Tomas Frydrych <tf@o-hand.com> wrote:
> >
> > Dominic Lachowicz wrote:
> > >> I agree, I think this should got into the 2.6 tree after the 2.6.0
> > >> release, so it is ready for 2.6.1 (it is non-invasive feature, that is
> > >> easy to turn off again, should that become necessary).
> > >
> > > I'd might prefer that it didn't quite yet, because undo doesn't work
> > > properly. Type "Hello World". Undo'ing turns curly quotes into
> > > straight quotes, so you have to undo twice to get rid of the quote.
> >
> > That's by design, I told Bobby it should be possible to undo the auto
> > replacement that way (word does it like that, and I recall using it
> > quite often, for what that is worth); I think also without this the old
> > undo/redo problem might resurface.
> >
> > Tomas
> >
> >
>
>
>
> --
> Counting bodies like sheep to the rhythm of the war drums.
>
Received on Mon Mar 17 20:20:26 2008