Re: frt - r23998 - abiword/branches/gsoc2008ooxml/plugins/openxml/exp/xp

On Sat, 2008-05-24 at 01:03 +0200, cvs@abisource.com wrote:
> Author: frt
> Date: 2008-05-24 01:03:39 +0200 (Sat, 24 May 2008)
> New Revision: 23998
>
> Modified:
> abiword/branches/gsoc2008ooxml/plugins/openxml/exp/xp/ie_exp_OpenXML.cpp
> abiword/branches/gsoc2008ooxml/plugins/openxml/exp/xp/ie_exp_OpenXML.h
> abiword/branches/gsoc2008ooxml/plugins/openxml/exp/xp/ie_exp_OpenXML_Sniffer.cpp
> Log:
> OpenXML Exporter is extended to create an empty valid .docx file

Congrats, nice start :)

One lil' nitpick:

> + if(sink != NULL){

could you start the opening brace '{' on a new line? That's consistent
with the rest of our code. Some dislike it, some like it, but that's how
it is :)

Rock on,
  Marc
Received on Sat May 24 01:27:48 2008