Re: msevior - r24937 - abiword/trunk/src/text/fmt/xp

Thanks for the tip Marc!

Will investigate further now that I know where the problem is.

I'm pretty sure we can nail this.

Cheers

Martin

On Fri, Oct 17, 2008 at 8:09 AM, J.M. Maurer <uwog@uwog.net> wrote:
>
> On Thu, 2008-10-16 at 09:18 +0200, cvs@abisource.com wrote:
>> Author: msevior
>> Date: 2008-10-16 09:18:21 +0200 (Thu, 16 Oct 2008)
>> New Revision: 24937
>>
>> Modified:
>> abiword/trunk/src/text/fmt/xp/fp_TextRun.cpp
>> Log:
>>
>> Fix merging runs to allow liguatures to work. This could substantially help
>> Arabic and complex script rendering. Please backport to 2.6
>
> I think this bug is similar:
>
> http://bugzilla.abisource.com/show_bug.cgi?id=11665
>
> ... and from my limited testing, we're still breaking runs all over te
> place, and not merging them correctly. I'd be surprised if your fix was
> the 'final' solution :)
>
> Cheers!
> Marc
>
>>
>>
>> Modified: abiword/trunk/src/text/fmt/xp/fp_TextRun.cpp
>> ===================================================================
>> --- abiword/trunk/src/text/fmt/xp/fp_TextRun.cpp 2008-10-15 22:45:43 UTC (rev 24936)
>> +++ abiword/trunk/src/text/fmt/xp/fp_TextRun.cpp 2008-10-16 07:18:21 UTC (rev 24937)
>> @@ -1027,7 +1027,7 @@
>> //
>> PD_StruxIterator text(getBlock()->getStruxDocHandle(),
>> getBlockOffset() + fl_BLOCK_STRUX_OFFSET);
>> - text.setPosition(getLength()-1);
>> + text.setPosition(getLength());
>> if(UT_UCS4_isspace(text.getChar()))
>> {
>> return false;
>>
>> -----------------------------------------------
>> To unsubscribe from this list, send a message to
>> abisource-cvs-commit-request@abisource.com with the word
>> unsubscribe in the message body.
>
>
Received on Fri Oct 17 00:49:17 2008