Re: FW: [Bug 4736] - Need to export a AtkAccessible interface for the editing widget

Hi Mike,
           OK there are a few problems.

Firstly in the cross platform layer,

src/text/fmt/xp

You have the header file:

fa_Object.h

Which has content:

----------------------------------------------
/* Accessibility support or the AbiWord Document Widget
 *
 * Copyright (C) 2008 Michael Gorse
 *
 * This program is free software; you can redistribute it and/or
 * modify it under the terms of the GNU General Public License
 * as published by the Free Software Foundation; either version 2
 * of the License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA
 * 02111-1307, USA.
 */
#ifndef fa_OBJECT_H
#define fa_OBJECT_H

#include <gtk/gtk.h>
#include <atk/atk.h>
#include <gail/gailwidget.h>
---------------------------------------------------

I needed

#include <gail-1.0/gail/gailwidget.h>

To get this to compile on Fedora-9 distro.

But a much bigger problem is that gtk should not be a dependency in
src/text/fmt/xp.

Could you reconfigure your code to have subclasses in the directory

src/text/fmt/gtk

Which have the gtk dependencies?

see

src/text/fmt/xp/fv_VisualDragText.(h,cpp) and
src/text/fmt/gtk/fv_UnixVisualDragText.(h,cpp)

for examples of how we separate gtk specific code the in the text/fmt layer.
----------------------------------------------------------

Finally I got this error compiling src/wp/ap/gtk/ap_DocView.cpp

 -O0 -g -I/home/msevior/abidir/include -Wall -Wextra -Wsign-compare
-Wpointer-arith -Wchar-subscripts -Wwrite-strings -Wmissing-noreturn
-Wunused -Wpointer-arith -Wshadow -MT ap_DocView.lo -MD -MP -MF
.deps/ap_DocView.Tpo -c -o ap_DocView.lo
../../../../../abiword/src/wp/ap/gtk/ap_DocView.cpp
In file included from ../../../../../abiword/src/wp/ap/gtk/ap_DocView.cpp:29:
../../../../../abiword/src/wp/ap/gtk/at_DocView.h:25:29: error:
gail/gailwidget.h: No such file or directory
../../../../../abiword/src/wp/ap/gtk/ap_DocView.cpp: In function
'GType ap_DocView_get_type()':
../../../../../abiword/src/wp/ap/gtk/ap_DocView.cpp:88: warning:
missing initializer for member '_GTypeInfo::value_table'
make[5]: *** [ap_DocView.lo] Error 1

Cheers!

Martin

On my fedora-9 distro
On Sun, Sep 7, 2008 at 10:35 PM, Martin Edmund Sevior
<martines@unimelb.edu.au> wrote:
>
>
>
> -----Original Message-----
> From: AbiSource Bugzilla service [mailto:bugzilla-daemon@abisource.com]
> Sent: Sun 9/7/2008 3:11 AM
> To: msevior@physics.unimelb.edu.au
> Subject: [Bug 4736] - Need to export a AtkAccessible interface for the
> editing widget
>
> ** THIS IS AN AUTOMATED NOTIFICATION **
> ** Don't reply to this mail. Reply in Bugzilla at the URL **
> ** below. Mail sent directly to developers is ignored! **
>
> http://bugzilla.abisource.com/show_bug.cgi?id=4736
>
>
> mgorse@alum.wpi.edu changed:
>
> What |Removed |Added
> ----------------------------------------------------------------------------
> Attachment #4459 is|0 |1
> obsolete| |
>
>
>
>
> ------- Comment #12 from mgorse@alum.wpi.edu 2008-09-06 19:11 -------
> Created an attachment (id=4676)
> --> (http://bugzilla.abisource.com/attachment.cgi?id=4676&action=view)
> Slightly updated patch
>
> Updated patch; adds some comments and fixes a couple of issues. Sorry for
> the
> long hiatus.
>
>
Received on Mon Sep 8 02:45:58 2008