Re: frt - r27479 - abiword/trunk/plugins/openxml/imp/xp

On Sun, Aug 2, 2009 at 2:54 AM, <cvs@abisource.com> wrote:
>
> Author: frt
> Date: 2009-08-02 08:54:03 +0200 (Sun, 02 Aug 2009)
> New Revision: 27479
>
> Modified:
>   abiword/trunk/plugins/openxml/imp/xp/OXMLi_ListenerState_Valid.cpp
>   abiword/trunk/plugins/openxml/imp/xp/OXMLi_ListenerState_Valid.h
>   abiword/trunk/plugins/openxml/imp/xp/OXMLi_StreamListener.cpp
>   abiword/trunk/plugins/openxml/imp/xp/OXMLi_Types.h
> Log:
> OpenXML importer added checks for some valid keywords (main document story, paragraphs)
>

Hi Firat,

I'm not sure this sort of validation is a good idea for (at least) two reasons:

- AbiWord has been producing invalid files for a while (Bug 12180).
If you only accept invalid input, you're going to break compatibility
with old files.

- Office programs should handle a wide variety of input. It doesn't
serve the needs of users to reject technically invalid documents that
could be imported otherwise. In fact, a lot of work has been done
during 2.7.x to make AbiWord accept broken files.

I don't think the importer should _require_ strict validity. Instead,
the code would probably be most helpful as a means of warning users of
broken files (and accepting them regardless), and also as a way to
help developers validate files that AbiWord produces. Beyond that, I
see it causing more problems than it solves.
Received on Sun Aug 2 09:49:25 2009