Re: uwog - r25688 - abiword/trunk/plugins/opendocument/exp/xp

It looks to me as if the compiler should have been able to catch this.
Isn't there a "useless statement" warning we can enable?

Cheers,
  Marc

On Sun, 2009-02-15 at 20:50 +0100, cvs@abisource.com wrote:
> Author: uwog
> Date: 2009-02-15 20:50:05 +0100 (Sun, 15 Feb 2009)
> New Revision: 25688
>
> Modified:
> abiword/trunk/plugins/opendocument/exp/xp/ODe_Style_Style.cpp
> Log:
> Fix 11941: Cell border colors are not exported (always black). Please backport.
>
>
>
> Modified: abiword/trunk/plugins/opendocument/exp/xp/ODe_Style_Style.cpp
> ===================================================================
> --- abiword/trunk/plugins/opendocument/exp/xp/ODe_Style_Style.cpp 2009-02-15 17:38:34 UTC (rev 25687)
> +++ abiword/trunk/plugins/opendocument/exp/xp/ODe_Style_Style.cpp 2009-02-15 19:50:05 UTC (rev 25688)
> @@ -1522,7 +1522,7 @@
>
> ok = rAP.getProperty("left-color", pValue);
> if (ok && pValue != NULL) {
> - m_leftColor == pValue;
> + m_leftColor = pValue;
> } else if (m_leftColor.empty()) {
> m_leftColor = "000000";
> }
> @@ -1538,7 +1538,7 @@
>
> ok = rAP.getProperty("right-color", pValue);
> if (ok && pValue != NULL) {
> - m_rightColor == pValue;
> + m_rightColor = pValue;
> } else if (m_rightColor.empty()) {
> m_rightColor = "000000";
> }
> @@ -1554,7 +1554,7 @@
>
> ok = rAP.getProperty("top-color", pValue);
> if (ok && pValue != NULL) {
> - m_topColor == pValue;
> + m_topColor = pValue;
> } else if (m_topColor.empty()) {
> m_topColor = "000000";
> }
> @@ -1570,7 +1570,7 @@
>
> ok = rAP.getProperty("bot-color", pValue);
> if (ok && pValue != NULL) {
> - m_bottomColor == pValue;
> + m_bottomColor = pValue;
> } else if (m_bottomColor.empty()) {
> m_bottomColor = "000000";
> }
>
> -----------------------------------------------
> To unsubscribe from this list, send a message to
> abisource-cvs-commit-request@abisource.com with the word
> unsubscribe in the message body.
Received on Sun Feb 15 21:09:03 2009