Re: zooplah - r26863 - in abiword/branches/gsoc2009gettext: . src/af/xap/xp src/wp/ap/cocoa src/wp/ap/win src/wp/ap/xp

On 6/17/09, Hubert Figuiere <hfiguiere@teaser.fr> wrote:
>
> On 06/16/2009 10:31 PM, cvs@abisource.com wrote:
>> Modified: abiword/branches/gsoc2009gettext/src/wp/ap/cocoa/ap_CocoaApp.cpp
>> ===================================================================
>> ---
>> abiword/branches/gsoc2009gettext/src/wp/ap/cocoa/ap_CocoaApp.cpp 2009-06-16
>> 18:30:27 UTC (rev 26862)
>> +++
>> abiword/branches/gsoc2009gettext/src/wp/ap/cocoa/ap_CocoaApp.cpp 2009-06-17
>> 02:31:32 UTC (rev 26863)
>
> [...]
>
>> @@ -328,40 +328,6 @@
>> szPathname += ".strings";
>> #endif
>>
>> - NSString* stringSet = [resources
>> stringByAppendingPathComponent:[NSString
>> stringWithFormat:@"AbiWord/strings/%s%@",szStringSet,@".strings"]];
>> -
>> - AP_DiskStringSet * pDiskStringSet = new AP_DiskStringSet(this);
>> - UT_ASSERT(pDiskStringSet);
>> -
>> - if (pDiskStringSet->loadStringsFromDisk([stringSet UTF8String]))
>> - {
>> - pDiskStringSet->setFallbackStringSet(m_pStringSet);
>> - m_pStringSet = pDiskStringSet;
>> - UT_DEBUGMSG(("Using StringSet [%s]\n",[stringSet UTF8String]));
>> - }
>> - else
>> - {
>> - DELETEP(pDiskStringSet);
>> - UT_DEBUGMSG(("Unable to load StringSet [%s] -- using builtin strings
>> instead.\n",[stringSet UTF8String]));
>> - }
>> - }
>> - }
>> -
>> - // Now we have the strings loaded we can populate the field names
>> correctly
>> - int i;
>> -
>> - for (i = 0; fp_FieldTypes[i].m_Type != FPFIELDTYPE_END; i++)
>> - {
>> - (&fp_FieldTypes[i])->m_Desc =
>> m_pStringSet->getValue(fp_FieldTypes[i].m_DescId);
>> - UT_DEBUGMSG(("Setting field type desc for type %d, desc=%s\n",
>> fp_FieldTypes[i].m_Type, fp_FieldTypes[i].m_Desc));
>> - }
>> -
>> - for (i = 0; fp_FieldFmts[i].m_Tag != NULL; i++)
>> - {
>> - (&fp_FieldFmts[i])->m_Desc =
>> m_pStringSet->getValue(fp_FieldFmts[i].m_DescId);
>> - UT_DEBUGMSG(("Setting field desc for field %s, desc=%s\n",
>> fp_FieldFmts[i].m_Tag, fp_FieldFmts[i].m_Desc));
>> - }
>> -
>>
>> ///////////////////////////////////////////////////////////////////////
>> /// Build a labelset so the plugins can add themselves to something
>> ///
>>
>> ///////////////////////////////////////////////////////////////////////
>
>
> This change completely break as you don't even remove the whole block
> leaving a bracket open.
>
> I have a patch if you really want.
>

Sorry about that. I was trying to remove references to classes that
no longer even exist, but I don't have access to a Mac for testing.
Sure, send the patch.
Received on Wed Jun 17 16:33:43 2009