RE: msevior - r25912 - abiword/trunk/src/af/gr/xp

Sorry, totally missed that while working through my mail backlog. Thanks
for the fix!

  Marc

On Sat, 2009-03-14 at 10:05 +1100, Martin Edmund Sevior wrote:
>
>
>
>
> Marc, you are totally correct.
>
> I fixed it properly a day later.
>
> Cheers
>
> Martin
>
> -----Original Message-----
> From: owner-abiword-dev@abisource.com on behalf of J.M. Maurer
> Sent: Sat 3/14/2009 1:30 AM
> To: Martin Sevior
> Cc: abiword-dev; Luca Padovani; Erik Heinz
> Subject: Re: msevior - r25912 - abiword/trunk/src/af/gr/xp
>
>
> On Wed, 2009-03-11 at 23:16 +1100, Martin Sevior wrote:
> > Actually this commit fixes bug 11982. "AbiMathView rendering
> problems"
> >
> > It was caused because the left extent can sometimes go very
> slightly
> > negative and abiword's UT_Rect class holds only unsigned integers.
>
> Aren't negative extends perfectly valid? If so, the correct fix sounds
> to me holding it in a signed integer, not just deleting potentially
> important information.
>
> Cheers!
> Marc
>
> > This fix was simply to limit the minimum left extent to 0.
> >
> > Please back port this Marc!
> >
> > Cheers!
> >
> > Martin
> >
> ------------------------------------------------------------------------
> >
> > Author: msevior
> > Date: 2009-03-11 13:04:22 +0100 (Wed, 11 Mar 2009)
> > New Revision: 25912
> >
> > Modified:
> > abiword/trunk/src/af/gr/xp/gr_CairoGraphics.cpp
> > Log:
> > fix bug 11932
> > text following an equation is not always printed at the right place.
> >
> > Please backport.
>
>
>
>
Received on Sat Mar 14 19:56:44 2009