Re: pradeeban - r26656 - in abiword/branches/gsoc2009unicode/src: af/util/xp wp/ap/xp

On 05/31/2009 08:51 AM, cvs@abisource.com wrote:

> Modified: abiword/branches/gsoc2009unicode/src/af/util/xp/ut_string_class.h
> ===================================================================
> --- abiword/branches/gsoc2009unicode/src/af/util/xp/ut_string_class.h 2009-05-31 07:25:47 UTC (rev 26655)
> +++ abiword/branches/gsoc2009unicode/src/af/util/xp/ut_string_class.h 2009-05-31 12:51:15 UTC (rev 26656)
> @@ -109,7 +109,7 @@
> // even if to an empty string.
> const char* c_str() const;
>
> -private:
> +protected:
> class UT_StringImpl<char>* pimpl;
> };
>
> @@ -369,7 +369,7 @@
>
> const char * utf8_str ();
>
> -private:
> +protected:
> void _loadUtf8(const char * utf8_str, size_t bytelength); // implementation detail for the UTF-8 constructor
> class UT_StringImpl<UT_UCS4Char>* pimpl;
> };
>

Why do you need to do that? I see no reason to make these "protected".

> Modified: abiword/branches/gsoc2009unicode/src/wp/ap/xp/ap_App.cpp
> ===================================================================
> --- abiword/branches/gsoc2009unicode/src/wp/ap/xp/ap_App.cpp 2009-05-31 07:25:47 UTC (rev 26655)
> +++ abiword/branches/gsoc2009unicode/src/wp/ap/xp/ap_App.cpp 2009-05-31 12:51:15 UTC (rev 26656)
> @@ -32,7 +32,7 @@
> #include "xap_Frame.h"
> #include "xap_ModuleManager.h"
> #include "pd_Document.h"
> -
> +#include "ut_Win32LocaleString.h"
> #include "ie_imp.h"

You are in an XP file. This will break....

Hub
Received on Sun May 31 16:13:07 2009