Re: msevior - r28839 - abiword/trunk/src/text/fmt/xp

From: Martin Sevior <msevior_at_gmail.com>
Date: Sat Apr 17 2010 - 02:15:29 CEST

Hi Marc,

the old code was clearly wrong but very unlikely to ever get
triggered. I think we'd need sum1 to think very carefully to compose a
good test case.

It should be backported.

Cheers

Martin

On Fri, Apr 16, 2010 at 10:29 PM, J.M. Maurer <uwog@uwog.net> wrote:
>
> On Thu, 2010-04-15 at 12:02 +0200, cvs@abisource.com wrote:
>> Author: msevior
>> Date: 2010-04-15 12:02:31 +0200 (Thu, 15 Apr 2010)
>> New Revision: 28839
>>
>> Modified:
>>    abiword/trunk/src/text/fmt/xp/fv_View_protected.cpp
>> Log:
>>
>> Fix selection bug.
>
> What does it fix exactly, and do I have to backport it?
>
>  Marc
>
>>
>>
>> Modified: abiword/trunk/src/text/fmt/xp/fv_View_protected.cpp
>> ===================================================================
>> --- abiword/trunk/src/text/fmt/xp/fv_View_protected.cpp       2010-04-15 03:02:33 UTC (rev 28838)
>> +++ abiword/trunk/src/text/fmt/xp/fv_View_protected.cpp       2010-04-15 10:02:31 UTC (rev 28839)
>> @@ -3615,7 +3615,7 @@
>>       getEditableBounds(false,posBOD);
>>       getEditableBounds(true,posEOD);
>>       if(dNewPoint < posBOD || dNewPoint > posEOD || dOldPoint < posBOD
>> -        || dNewPoint > posEOD)
>> +        || dOldPoint > posEOD)
>>       {
>>               return;
>>       }
>>
>> -----------------------------------------------
>> To unsubscribe from this list, send a message to
>> abisource-cvs-commit-request@abisource.com with the word
>> unsubscribe in the message body.
>
>
>
Received on Sat Apr 17 02:15:45 2010

This archive was generated by hypermail 2.1.8 : Sat Apr 17 2010 - 02:15:45 CEST