Re: Re: Chen Xiajian_Another two bugs about Table I post in the Bugzilla

On Wed, Apr 20, 2011 at 7:36 AM, chenxiajian1985
<chenxiajian1985@gmail.com> wrote:
> similar to the implementation of ProgressBar
> Firstly, He add some common code in the abstract class AP_StatusBarField_ProcessBar
> and then add specific code in the different platform such as AP_Win32StatusBar and Ap_UnixStatusBar or AP_UnixStatusBar....

True. Though he implemented the OS specific code only for Unix, he did
a minor change to Win code to make sure that Win code builds without
failure till someone implements it completely for win, iirc. You may
do the same, in that case.

Marking //todo:{pointers_to_what_to_be_done} in the relevant places in
cocoa and gtk would be a nice idea, so that fidencio and someone would
be able to locate the code pretty easily and implement accordingly for
cocoa and gtk.

>
>
> what I need to do:
> 1. check the bug unfixed now
> 2. find whether to change the code in core or specific platform
> so I need to care about the code about implement Table

Excellent!

Thank you.
Regards,
Pradeeban.

> Thanks
>
> chen xiajian
>
>
>
> 发件人： Kathiravelu Pradeeban
> 发送时间： 2011-04-20 09:52:26
> 收件人： Fabiano_Fid阯cio
> 抄送： chenxiajian1985; msevior; abiword-dev
> 主题： Re: Chen Xiajian_Another two bugs about Table I post in the Bugzilla
>
> Hi,
> On Wed, Apr 20, 2011 at 2:09 AM, Fabiano Fidêncio <fabiano@fidencio.org> wrote:
>>
>> On Tue, Apr 19, 2011 at 11:03 AM, chenxiajian1985
>> <chenxiajian1985@gmail.com> wrote:
>>>
>>> Hi, All.
>>> Bug 13053 and Bug 13052
>>> If everyone agree with me, I try to fix them
>>
>> Chen,
>>
>> If you want to work in one non-assinged bug, you're free to do it
>> without talk with any one, just do it.
>> If you want to work in one assigned bug, the good practices says that
>> you need talk with the guy that is "spenting" his time workin' in the
>> bug, to avoid re-work.
>>
>> Just assign the bug to you on bugzilla and good hack! It's the Open
>> Source community way of life :-)
> There is one point to note Fidencio. Some of the bugs are fixed
> recently, and the bugzilla hasn't been updated accordingly. So asking
> once over irc or mailing list is not a bad idea as well, if not sure..
> ;)
>>
>>>
>>> ========================================
>>> Bug 13052:
>>> the font in the table can't be modified correctly
>>> when I create a table, and I selected the first row, and change the font, I find that the font of the cell where the cursor in can't be modified correctly (it stay in the former size)
>>> ========================================
>>> Bug 13053:
>>> the font never modify when using "tab" to shift from one cell to next cell
>>> when the cells have different font or fontsize. using "tab" to shift from one cell to next cell, the font in the toolbar is not indecated correctly
>>>
>>> And about the Linux/OSX platform?
>>
>> I didn't get you question.
>> If the bug is in AbiCore, there's no differente for Linux/OSX. So, you
>> can fix it and close the bug :-)
>> If not, if there's some problem in specific platform, you can solve it
>> in your platform (in this case, Windows) and open 2 bugs relating your
>> closed bug.
>> Martin did something similar whit it when he implemented ProgressBar.
>> He implemented in Linux and sent to ML a mail saying that someone
>> needs implement it to Windows/OS X ... and I think that's the better
>> way to do it :-)
> Martin actually implemented the core of the logic in common place (xp)
> and put the linux specific presentation layer logic in gtk folder. So
> we had to use the common logic and just implement only the OS specific
> presentation layer logic for win and cocoa.
> Always place the reusable code in the common place, and OS specific
> code in their respective folders (win, gtk, cocoa). Adhering to this
> separation, we effectively reuse the code and make it portable as much
> as possible.
> Thank you.
> Regards,
> Pradeeban.
>>
>>>
>>>
>>> Chen Xiajian
>>>
>>>
>>>
>>
>>
>> Best Regards,
>> --
>> Fabiano Fidêncio
>>
> --
> Kathiravelu Pradeeban.
> Software Engineer.
> WSO2 Inc.
> Blog: [Llovizna] http://kkpradeeban.blogspot.com/
>

-- 
Kathiravelu Pradeeban.
Software Engineer.
WSO2 Inc.
Blog: [Llovizna] http://kkpradeeban.blogspot.com/