On Mon, 2011-07-04 at 10:58 +0200, cvs@abisource.com wrote:
> Modified: abiword/trunk/src/af/xap/xp/xap_Dlg_HTMLOptions.cpp
> ===================================================================
> --- abiword/trunk/src/af/xap/xp/xap_Dlg_HTMLOptions.cpp 2011-07-03
> 20:42:45 UTC (rev 29928)
> +++ abiword/trunk/src/af/xap/xp/xap_Dlg_HTMLOptions.cpp 2011-07-04
> 08:58:17 UTC (rev 29929)
> @@ -27,6 +27,8 @@
> #include "xap_App.h"
> #include "xap_Prefs.h"
> #include "xap_Dlg_HTMLOptions.h"
> +#include "xap_UnixDialogHelper.h"
> +#include "ut_Encoding.h"
The xap_UnixDialogHelper.h include is wrong: if you need to include the
platform header file in the crossplatform header file, then your design
is wrong. The other way around is the correct way to have the includes.
This commit breaks the Windows build, since we don't have access to the
unix headers during the Windows build (for obvious reasons).
Cheers,
Marc
Received on Mon Jul 4 17:18:22 2011
This archive was generated by hypermail 2.1.8 : Mon Jul 04 2011 - 17:18:22 CEST