Committed! Re: Image dlg and scaling

Committed.

Thanks very much Simon! Welcome to AbiWord :-)

Cheers

Martin

Modified:
   abiword/trunk/AUTHORS
   abiword/trunk/src/af/xap/gtk/xap_UnixDlg_Image.cpp
   abiword/trunk/src/af/xap/gtk/xap_UnixDlg_Image.h
   abiword/trunk/src/af/xap/xp/xap_Dlg_Image.cpp
   abiword/trunk/src/af/xap/xp/xap_Dlg_Image.h
   abiword/trunk/src/text/fmt/xp/fp_Run.cpp
   abiword/trunk/src/wp/ap/xp/ap_EditMethods.cpp
Log:

Lots of image dialog fixes from Simon Larochelle's first contribution.
Thank you very much Simon!

On Sat, Jul 2, 2011 at 11:53 PM, Simon Larochelle
<larochelle.simon.1@gmail.com> wrote:
> Hi,
>
> I made a patch to fix the following issues with the image dialog in
> Abiword 2.8.6:
>
>
> 1) For images that are bigger than the frame size, the image
> dimensions are not saved correctly. When first opening the image
> dialog, the max frame width and height are shown instead of the width
> and height of the image as displayed (with the correct aspect ratio).
> Also, if I try to rescale the image with the mouse and than use the
> "undo" command, the image width and height are changed to the max
> frame width and height.
>
> 2) In the image dialog, "Preserve aspect ratio" is not respected when
> trying to increment the height of an image with its width already at
> its maximum (or vice-versa)
>
> 3) In the image dialog, it is not possible to simultaneously change
> the image dimensions and the wrapping mode from "wrapped ..." to
> "inline".
>
> 4) In the image dialog, it is not possible to simultaneously set the
> image title (or description) and the wrapping mode from "inline" to
> "wrapped ..." (sometimes this even makes the image disappear).
>
> 5) For an inline image, if I select "set positionned image" (context
> menu) and then open the image dialog, the width and height are always
> displayed in inches irrespective of the user preferences.
>
> 6) Images are limited to 95% of the frame dimensions. This is not
> really a bug, but is there a good reason why the image dimensions
> should not get to 100% of the frame dimension?
>
> 7) A GTK specific issue: in the image dialog, typing a new width (or
> height) is difficult as the field content is check after any character
> change ("changed" signal instead of "activate" and "focus out"
> signals).
>
>
> N.B.: Items 1 and 6 are mentioned in Bug 8577. Bug 9664 may be a
> relative of item 1.
>
>
> Simon
>
Received on Mon Jul 18 02:37:26 2011