Re: pradeeban - r29812 - enchant/tags/release-2-2-2

Hi Marc,
Oops. Just realized that 1.6.0 is the latest. I got confused due to
the fact that 2-2-2 > 1.6.0, and was also concerned that the latest
enchant tag was not building with the later versions of Automake.
Anyway just noticed that 1.6.0 already has this fix. So we won't need
this change for 1.6.0 anyway (or creating 1.6.1 tag for this purpose).
1.6.0 builds perfectly out of the box.

Thanks for clarifying this version issues over irc, and attending to this.

Thank you.
Regards,
Pradeeban.

On Sun, Jun 19, 2011 at 7:40 PM, J.M. Maurer <uwog@uwog.net> wrote:
>
> Please don't commit to tags, especially after they have been released.
> The proper fix is to just make a new release (that would be 1.6.1).
>
> Tag 2.2.2 is ancient, so we should not commit in that:
>
> ------------------------------------------------------------------------
> r20990 | (no author) | 2004-11-21 22:45:32 +0100 (Sun, 21 Nov 2004) | 2
> lines
>
> This commit was manufactured by cvs2svn to create tag
> 'release-2-2-2'.
> ------------------------------------------------------------------------
>
> Thanks for taking the time to fix the build issue though.
>
> Cheers!
>  Marc
>
>
>
> On Sat, 2011-06-11 at 17:05 +0200, cvs@abisource.com wrote:
>> Author: pradeeban
>> Date: 2011-06-11 17:05:29 +0200 (Sat, 11 Jun 2011)
>> New Revision: 29812
>>
>> Modified:
>>    enchant/tags/release-2-2-2/autogen.sh
>> Log:
>> Fix to make building the enchant tag 2.2.2 work with automake-1.10+ [Backporting the fix from the trunk].
>>
>>
>>
>> Modified: enchant/tags/release-2-2-2/autogen.sh
>> ===================================================================
>> --- enchant/tags/release-2-2-2/autogen.sh     2011-06-11 10:56:40 UTC (rev 29811)
>> +++ enchant/tags/release-2-2-2/autogen.sh     2011-06-11 15:05:29 UTC (rev 29812)
>> @@ -10,7 +10,7 @@
>>
>>  rm -f autogen.err
>>
>> -automake --version | perl -ne 'if (/\(GNU automake\) ([0-9].[0-9])/) {print;  if ($1 < 1.4) {exit 1;}}'
>> +automake --version | perl -ne 'if (/\(GNU automake\) (([0-9]+).([0-9]+))/) {print; if ($2 < 1 || ($2 == 1 && $3 < 4)) {exit 1;}}'
>>
>>  if [ $? -ne 0 ]; then
>>      echo "Error: you need automake 1.4 or later.  Please upgrade."
>>
>> -----------------------------------------------
>> To unsubscribe from this list, send a message to
>> abisource-cvs-commit-request@abisource.com with the word
>> unsubscribe in the message body.
>
>
>

-- 
Kathiravelu Pradeeban.
Software Engineer.
WSO2 Inc.
Blog: [Llovizna] http://kkpradeeban.blogspot.com/