Re: Re: Bug fix _ Does we missing ut_strptime.h and ut_strptime.cpp

Applied MSVC patch from Diana, that fixes
http://bugzilla.abisource.com/show_bug.cgi?id=13284. Hence this issue
is fixed now.

Let me know, if there is something else remaining to be tested and committed.

Thank you.
Regards,
Pradeeban.

2012/4/2 vincent.abiword <vincent.abiword@gmail.com>:
> thanks hub
>
> yes. I have told to Predeeban. he will help me to have a code review about my patch in bug 13313.
>
>
> vincent.abiword
>
> From: Hubert Figuière
> Date: 2012-04-02 23:21
> To: abiword-dev
> Subject: Re: Bug fix _ Does we missing ut_strptime.h and ut_strptime.cpp
>
> On 01/04/12 11:19 PM, vincent vincent wrote:
>>
>> from the maillist log, I found that this thread is for fixing  ___
>> Build error on Windows because there is no "strptime".
>>
>> but from the latest build , I found the link error:
>> 1>Linking...
>> 1>   Creating library
>> F:\abiword\gsoc2012\abiword33\msvc2008\Debug\bin\LibAbiWord.lib and
>> object F:\abiword\gsoc2012\abiword33\msvc2008\Debug\bin\LibAbiWord.exp
>> 1>ut_std_string.obj : error LNK2019: unresolved external symbol
>> _UT_strptime referenced in function "__int64 __cdecl
>> parseTimeString(class std::basic_string<char,struct
>> std::char_traits<char>,class std::allocator<char> > const &)"
>> (?parseTimeString@@YA_JABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@Z)
>> 1>F:\abiword\gsoc2012\abiword33\msvc2008\Debug\bin\LibAbiWord.dll :
>> fatal error LNK1120: 1 unresolved externals
>>
>>
>> from the code, we can see that:  UT_strptime is implemented in UT_strptime.cpp
>>
>> but this file is missing
>
> No, it is in UT_strptime.c
>
>
>>
>> so  I want to check that Does we missing ut_strptime.h and ut_strptime.cpp
>
> It is declared in ut_string.h
>
> All you need is to add the file to the MSVC project and submit a patch
> for those who can do (not me) commit it.
>
> Then we can actually close the bug that has the whole history.
>  http://bugzilla.abisource.com/show_bug.cgi?id=13284
>
> Hub

-- 
Kathiravelu Pradeeban.
Software Engineer.
WSO2 Inc.
Blog: [Llovizna] http://kkpradeeban.blogspot.com/