Runtime vs compile time (was: Re: ib - r30903 - abiword/trunk/plugins/wmf)

> Don't check runtime ability at compile time.
>
> Replace the check with an option.
>
> This fixes r30900.
>
>
> Modified: abiword/trunk/plugins/wmf/plugin.m4
> ===================================================================
> --- abiword/trunk/plugins/wmf/plugin.m4 2012-04-30 14:11:27 UTC (rev 30902)
> +++ abiword/trunk/plugins/wmf/plugin.m4 2012-04-30 14:15:10 UTC (rev 30903)
> @@ -7,6 +7,15 @@
> AC_PATH_PROG(libwmfconfig, libwmf-config)
> ])
>
> +AC_ARG_WITH([standard_symbols_l],
> + [AS_HELP_STRING([--with-standard-symbols-l], [use font family 'Standard Symbols L' for Symbol])],
> +[
> + abi_cv_standard_symbols_l="$withval"
> +])
> +if test "$abi_cv_standard_symbols_l" = "yes"; then
> + AC_DEFINE([WITH_STANDARD_SYMBOLS_L], [1], [Use font family 'Standard Symbols L' for Symbol])
> +fi
> +

This is probably as bad. Because you again assume a runtime condition at
compile time. And this is not good at all.

Hub
Received on Mon Apr 30 20:59:28 2012