Re: [PATCH] Improve GTK progress bar

From: Ingo Brückl <ib_at_wupperonline.de>
Date: Thu Mar 29 2012 - 13:35:42 CEST

Martin Sevior wrote on Thu, 29 Mar 2012 13:06:14 +1100:

> On Thu, Mar 29, 2012 at 2:15 AM, Ingo Brückl <ib@wupperonline.de> wrote:
>> The GTK progress bar currently bursts the status bar, because its default
>> height is too big. Fix this by requesting a height that will fit into the
>> status bar.
>>
>> If nobody objects, I'll commit.

> This look slike a patch to work around a gtk bug. Is that right?

Why do you think so? (Maybe my patch description was inaccurate, it should
read: "The GTK progress bar currently _might_ burst the status bar, because
its default height _might be_ too big.")

The height of the status bar is determined by the height of the children in
it. When starting AbiWord this is the height of the font used to render the
status bar texts. The default minimum height of a horizontal progress bar is
20. So, if you are using a small font, the status bar will grow in height
when the progress bar is drawn. By restricting the frame height the progress
bar is in to the height of the status bar, it will be drawn then with that
restricted height.

Ingo
Received on Thu Mar 29 13:48:26 2012

This archive was generated by hypermail 2.1.8 : Thu Mar 29 2012 - 13:48:26 CEST