Re: ib - r31881 - in abiword/trunk: plugins/wmf src/af/gr/xp src/text/ptbl/xp src/wp/ap/xp src/wp/impexp/xp

From: Jean Brefort <jean.brefort_at_normalesup.org>
Date: Sun Nov 18 2012 - 10:01:30 CET

This commit looks weird too, removing #include <config.h> looks
dangerous, any of the included files might need it, either now or in the
future. IMHO, all .cpp files should include it before everything else.
More, I don't see how this is related to the stadard symbols stuff.

Regards,
Jean

Le mercredi 05 septembre 2012 à 12:24 +0200, cvs@abisource.com a écrit :
> Author: ib
> Date: 2012-09-05 12:24:33 +0200 (Wed, 05 Sep 2012)
> New Revision: 31881
>
> Modified:
> abiword/trunk/plugins/wmf/plugin.m4
> abiword/trunk/src/af/gr/xp/gr_CairoGraphics.cpp
> abiword/trunk/src/text/ptbl/xp/pt_PT_Styles.cpp
> abiword/trunk/src/wp/ap/xp/ap_Dialog_Lists.cpp
> abiword/trunk/src/wp/impexp/xp/ie_imp_RTF.cpp
> Log:
> Remove everything related to former option --with-standard-symbols-l.
>
> It's obsolete after r31870-r31872.
>
> Modified: abiword/trunk/src/af/gr/xp/gr_CairoGraphics.cpp
> ===================================================================
> --- abiword/trunk/src/af/gr/xp/gr_CairoGraphics.cpp 2012-09-05 07:30:59 UTC (rev 31880)
> +++ abiword/trunk/src/af/gr/xp/gr_CairoGraphics.cpp 2012-09-05 10:24:33 UTC (rev 31881)
> @@ -2596,11 +2596,7 @@
> if (szLCFontName)
> {
> xxx_UT_DEBUGMSG(("GR_CairoGraphics::setFont: %s\n", szLCFontName));
> -#ifdef WITH_STANDARD_SYMBOLS_L
> - if(strstr(szLCFontName,"standard symbols l") != NULL)
> -#else
> if(strstr(szLCFontName,"symbol") != NULL)
> -#endif
> {
> /*
> * I am not too happy about this, and do not want to see the exception
>
> Modified: abiword/trunk/src/text/ptbl/xp/pt_PT_Styles.cpp
> ===================================================================
> --- abiword/trunk/src/text/ptbl/xp/pt_PT_Styles.cpp 2012-09-05 07:30:59 UTC (rev 31880)
> +++ abiword/trunk/src/text/ptbl/xp/pt_PT_Styles.cpp 2012-09-05 10:24:33 UTC (rev 31881)
> @@ -19,9 +19,6 @@
> * 02111-1307, USA.
> */
>
> -#ifdef HAVE_CONFIG_H
> -#include "config.h"
> -#endif
> #include "ut_locale.h"
> #include "ut_types.h"
> #include "ut_misc.h"
>
Received on Sun Nov 18 10:03:18 2012

This archive was generated by hypermail 2.1.8 : Sun Nov 18 2012 - 10:03:18 CET