Re: About Table header

Hi Martin,

Thanks for your advice. I will double check the commit logs and code
diff from Kousik's branch.

And try to do it one by one:
1. go though the commit code one by one
2. find out what Kousik have done and the way how he get the problem solved
3. try to merge the branch's code piece by piece.
4. thinking for missing works.

BTW, thanks very much for giving me the chance to work on Abiword this summer,
thanks

Joe

On Wed, May 29, 2013 at 2:15 PM, Martin Sevior <msevior@gmail.com> wrote:
> Hi Joe,
>
> The changes committed by Simon were extensive but mostly involved the
> internal layout of the cells within the table. We may be able able to
> isolate code written to reposition table rows broken across pages to
> take account of the space provided by the repeated rows.
>
> If not it might be easier to simply rewrite the table breaking code
> developed by Kuosik to make it fit within the developments made by
> Simon.
>
> So in other words: I'd try a two step approach.
>
> 1. See if you can do a direct patch against current SVN from Kousik's code.
>
> If that appears hopeless, then make a diff between Kuosiks code and
> abiword svn at the beginning of 2012.
>
> Use the diff to see what needs to change in current abiword svn to
> incorporate repeated rows on tables broken across pages.
>
> Joe, I will mentor you in 2013 so feel free to send me private emails
> with the diff's so I can advise. Simon, it would be great to get your
> insight as well.
>
> Cheers
>
> Martin
>
>
> On 28 May 2013 23:25, joe joe <joegsoc2013@gmail.com> wrote:
>> Hi Simon,
>>
>> Thanks for all mentors for giving me the chance to work for Abiword on
>> this GSOC.
>>
>> Can you share with me some information about your big changes to the
>> table code? That would be great help to me to dig into the code.
>>
>> I also try to merge the branch's code firstly.thanks
>> http://www.abisource.com/viewvc/abiword/branches/gsoc2012table_headers/
>>
>>
>> Joe
>>
>> On Thu, May 16, 2013 at 11:12 PM, joe joe <joegsoc2013@gmail.com> wrote:
>>> Hi Simon,
>>>
>>> Yes, you are right. the right branch is
>>> http://www.abisource.com/viewvc/abiword/branches/gsoc2012table_headers/
>>>
>>> Can you share with me some information about your big changes to the
>>> table code? That would be great help to me to dig into the code (
>>> Whether I can be selected by GSOC or not, it is a good opportunity for
>>> me to learning coding, thanks)
>>>
>>>
>>> Joe
>>>
>>> On Thu, May 16, 2013 at 9:38 PM, Simon Larochelle
>>> <larochelle.simon.1@gmail.com> wrote:
>>>> Hi Joe,
>>>>
>>>> The gsoc2010tableimprov branch is mostly about implementing a general
>>>> selection mechanism for cells inside a table. Kousik code is in the
>>>> branch gsoc2012table_headers. Note that merging Kousik branch with the
>>>> current trunk may not be easy because I made extensive changes to the
>>>> table code during the last year. I can give you a few pointers on what
>>>> you will need to modify if you are selected for GSOC.
>>>>
>>>> Simon
>>>>
>>>>
>>>> On Thu, May 16, 2013 at 2:24 AM, joe joe <joegsoc2013@gmail.com> wrote:
>>>>>
>>>>> HI Kousik,
>>>>>
>>>>> I am trying to merge the code of Branch gsoc2010tableimprov:
>>>>> http://www.abisource.com/viewvc/abiword/branches/gsoc2010tableimprov/
>>>>>
>>>>> I know that the frontend works and some of the backend works are still
>>>>> left. Can you give me a simple introduction about what you have done
>>>>> on the branch.
>>>>>
>>>>> I saw some words on Abiword GSOC 2013 idea list TWIKI page, but I want
>>>>> to get more information before merge. thanks
>>>>> That will be great help for me to dig into the code
>>>>>
>>>>>
>>>>>
>>>>> Thanks,
>>>>> Joe
>>>>>
>>>>> On Fri, Apr 19, 2013 at 11:04 PM, Kousik Kumar <kousikkumar771@gmail.com> wrote:
>>>>>> This is actually the function, from where the call to the backend should be
>>>>>> made. ap_EditMethods.cpp dispatches the UI calls. Nope, it is not yet
>>>>>> implemented. But in order to test the 2012 branch, you can modify the abw
>>>>>> file(specifically the table tag).
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Wed, Apr 17, 2013 at 8:49 AM, joe joe <joegsoc2013@gmail.com> wrote:
>>>>>>>
>>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>>
>>>>>>> About the Table improvement idea, It said that '"biWord's table
>>>>>>> support currently lacks the ability to make a selected row repeat at
>>>>>>> the top of every page the table is broken over. This useful for big
>>>>>>> tables with a heading above each column. Repeated rows allow the
>>>>>>> headings to be visible at the top of every page. This project would
>>>>>>> implement that."
>>>>>>>
>>>>>>>
>>>>>>> I found that the feature should be implemented on:
>>>>>>> abiword\src\wp\ap\xp\ap_EditMethods.cpp(16325):
>>>>>>> Defun0(repeatThisRow)
>>>>>>> {
>>>>>>> CHECK_FRAME;
>>>>>>> // ABIWORD_VIEW;
>>>>>>> return true;
>>>>>>> }
>>>>>>>
>>>>>>>
>>>>>>> Currently it is empty. Someone mentioned that some of the feature is
>>>>>>> implemented on branch gsoc2010tableimprov
>>>>>>>
>>>>>>> http://www.abisource.com/viewvc/abiword/branches/gsoc2010tableimprov/src/wp/ap/xp/ap_EditMethods.cpp?view=markup
>>>>>>>
>>>>>>> But it is also empty on Defun0(repeatThisRow).
>>>>>>>
>>>>>>> I think no one cover this feature, right?
>>>>>>>
>>>>>>>
>>>>>>> Joe
>>>>>>
>>>>>>
Received on Wed May 29 14:57:53 2013