Re: jbrefort - r34971 - abiword/trunk/src/wp/ap/gtk

From: Jean Bréfort <jean.brefort_at_normalesup.org>
Date: Wed Nov 12 2014 - 13:20:01 CET

Right, Attached patch is for abiword-3.0. With it the modify style
dialog does not grow up to the screen width, and the delete combo shows
something since with current code it shows only empty lines (with recent
gtk+, I don't know what happens with earlier versions)

Cheers,
Jean

Le mardi 11 novembre 2014 à 23:04 -0500, Hubert Figuière a écrit :
> On 11/11/14 04:12 AM, cvs@abisource.com wrote:
> >
> > Author: jbrefort
> > Date: 2014-11-11 10:12:14 +0100 (Tue, 11 Nov 2014)
> > New Revision: 34971
> >
> > Modified:
> > abiword/trunk/src/wp/ap/gtk/ap_UnixDialog_Styles.cpp
> > Log:
> > Fixed the style modify dialog. Please test and backport.
>
>
> Not sure what it fixes - so harder to test - but this surely conflicts
> with Gtk2 support as GtkGrid doesn't exists there.
> It is fine for trunk though.
>
>
> > @@ -919,9 +893,10 @@
> > gtk_widget_show (descriptionFrame);
> > gtk_box_pack_start (GTK_BOX (OverallVbox), descriptionFrame, FALSE, FALSE, 0);
> >
> > - DescriptionText = gtk_widget_new (GTK_TYPE_FRAME,
> > + DescriptionText = gtk_widget_new (GTK_TYPE_LABEL,
> > "xpad", 0, "ypad", 6,
> > "wrap", TRUE,
> > + "max-width-chars", 64,
> > NULL);
>
> Thank you for fixing this one. It was a typo / cut&paste error in one of
> my previous patch (trunk only) trunk@34959
>
>
>
> Thanks,
>
> Hub

Received on Wed Nov 12 13:20:09 2014

This archive was generated by hypermail 2.1.8 : Wed Nov 12 2014 - 13:20:09 CET