Subject: Re: libpng bug fixed - yipee
From: sam th (sam@bur-jud-118-039.rh.uchicago.edu)
Date: Thu Apr 13 2000 - 13:08:14 CDT
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Thu, 13 Apr 2000, Kevin Vajk wrote:
>
> Judging from comments on the abiword-user list, I would say
> that the bug you just fixed is the single biggest current
> abiword problem.
This is certainly the case, and I know that I considered it blocking anw
new release.
>
> Now, just a quick comment (ignore me if I'm on crack here):
>
> Would your fix still work if you reversed the order, so that
> you set the pointer *before* the call to png_set_read_fn()?
> Like this:
> png_ptr->io_ptr = &myBB; // Sam is a God
> png_set_read_fn(png_ptr, (void *)&myBB, _png_read);
>
Well, it seems to work.
What this means is that png_set_read_fn() isn't clobbering
png_ptr->io_ptr, it just isn't setting it properly.
As an additional question, does anyone know how to get GDB to step through
lines in a library? (I did compile with -g etc)
> It's just that I'd hate to mangle png_ptr if libpng makes
> some internal change to png_set_read_fn() in the future,
> which our hack might step on. Does this make sense?
>
Yeah, this does look better, and the fix really is a hack. I would like
to figure out what is going on in libpng.
> Again, ignore me if I don't know what I'm talking about. :)
>
> - Kevin Vajk
> <kvajk@ricochet.net>
>
>
Thanks
sam th
sytobinh@uchicago.edu
http://bur-jud-118-039.rh.uchicago.edu
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.1 (GNU/Linux)
Comment: For info see http://www.gnupg.org
iD8DBQE49g0Rt+kM0Mq9M/wRApZSAJ9EUbfyPF/tDUAiiKhxPaIoNd2+lACeKtD6
XPdtYXFyX5y/alY/ynQhrcY=
=MQa3
-----END PGP SIGNATURE-----
This archive was generated by hypermail 2b25 : Thu Apr 13 2000 - 13:08:31 CDT