Subject: Re: [Patch] Psiconv TextEd and Word importer
From: Frodo Looijaard (frodol@dds.nl)
Date: Wed Dec 20 2000 - 08:16:39 CST
Martin Sevior wrote:
>
> I had to change a bit of you code to compile: The relevent parts are:
>
> // This is only used for fixed string expansions, and should be big
> // enough in all circumstances.
> char buffer[256];
> ^^^^^^ Here!
Why make the buffer larger than 64 bytes? The largest string I print to
the buffer is about 32 bytes; even with severe overflow of numerics, 64
should be quite enough!
> int i;
> psiconv_tab tab;
>
> // background color: not yet implemented; what would its name be?!?
> strcat(buffer, "backcolor:");
> ^^^^^^ and Here!!!
> sprintf(buffer+strlen(buffer),"%02x%02x%02x",
> layout->back_color->red,
> layout->back_color->green,
> layout->back_color->blue);
>
Argh, That part should be commented out. The right stuff at this point:
#if 0
// background color: not yet implemented; what would its name be?!?
sprintf(buffer, "backcolor: %02x%02x%02x",
layout->back_color->red,
layout->back_color->green,
layout->back_color->blue);
props.append((unsigned char *) buffer,strlen(buffer));
#endif
I don't know how it became un-#if-ed...
Thanks,
Frodo
-- Frodo Looijaard <frodol@dds.nl> PGP key and more: http://huizen.dds.nl/~frodol Defenestration n. (formal or joc.): The act of removing Windows from your computer in disgust, usually followed by the installation of Linux or some other Unix-like operating system.
This archive was generated by hypermail 2b25 : Wed Dec 20 2000 - 08:20:03 CST