Subject: Re: StringPool
From: Aaron Lehmann (aaronl@vitelus.com)
Date: Sun Jul 16 2000 - 02:15:52 CDT
I've found a lot of hard-coded sizes throughout the source that I quite
frankly find disgusting and inflexible. Patches to make these more dynamic
would be appreciated.
Aaron Lehmann
On Sun, 16 Jul 2000, Allan Clark wrote:
> Hi
> I'm pretty new here and I'm looking through the source code to
> familiarize myself with the code.
> I think I might be wrong here but have a look at the implementation for the
> UT_StringPool class, in abi/src/af/util/xp/ut_pool.cpp
> in here it has a function called AddBucket() which adds a new bucket with
> space for 1024 chars, it also has a function AddString(const char *p), it
> checks to see if there is enough space in the Bucket at the head of the list
> for the given string to be added to, if not it creates a new Bucket using
> the aforementioned AddBucket and therefore with space for 1024 chars, now
> what if the string to be added is longer than 1024 chars? will this not
> cause it too crash?
>
>
> Allan Clark
> www.shark.org.uk
> adc@allanderek.freeserve.co.uk
> shark@blueyonder.co.uk
>
>
>
This archive was generated by hypermail 2b25 : Sun Jul 16 2000 - 02:15:58 CDT