Subject: Re: vector images
From: Paul Egli (pegli@sourcegear.com)
Date: Tue Jul 18 2000 - 10:04:07 CDT
This was committed one month ago. Yesterday I noticed that bug 642 had been
reintroduced into AbiWord. I've traced it back to this commit. The bug was
originally fixed by changing a line in abi/src/af/util/xp/ut_units.cpp from
this:
sprintf(buf,bufFormat,value);
to this:
sprintf(buf,bufFormat,valueScaled);
(see http://www.abisource.com/bugzilla/show_bug.cgi?id=642 for the diff).
I don't know if that was the correct way to fix it, but Justin changed it
back to:
sprintf(buf,bufFormat,value);
in his commit on 6/18 (Version 1.24 -> 1.25). This seems to have
reintroduced bug 642.
-Paul Egli
At 09:03 PM 6/18/00 -0500, Justin Bradford wrote:
>I've just committed the framework for vector images.
>
>This entailed changes in the af/gr code, adding support
>for multiple types of images. I've updated the other
>platforms, but not tested. I'll watch tinderbox, though,
>to make sure everything got through ok.
>
>I've also made minor changes throughout, adding the
>concept of a vector image and fixing the usage of gr_Image
>where needed.
>
>Finally, in the graphics importer section, I removed the
>hack (isPNG/isValidImage) from ap_EditMethods, for testing
>the image type, and instead added a RecognizeContents
>function on each of the graphics importers.
>
>
>As for the vector image, I have not really written any
>of its internals. Right now, if you insert/picture an
>svg file, it creates a new picture window on which I draw
>a green rectangle with an inscribed diamond. Just imagine
>that replaced by the actual drawing instructions.
>
>
>So, now I'll work on the internals of the vector image
>support, but I wanted to get the framework in before it
>became obsolete by other people's work.
>
>Justin
>
This archive was generated by hypermail 2b25 : Tue Jul 18 2000 - 10:02:20 CDT