Subject: Re: gnome-xml and policy
From: Martin Sevior (msevior@mccubbin.ph.unimelb.edu.au)
Date: Sat Jul 22 2000 - 03:05:06 CDT
Hi Goran,
I guess the first question that springs to mind is: What does
gnome-xml give us that expat doesn't?
Regarding patches, no patch should break the build, ever. We try to only
include patches that provide some advance in functionality even if it is
for only one platform. Although we make exceptions for long term pay-off.
For example I've made a number of changes to enable modeless dialogs in
Unix and Gnome that have broken specific dialogs on Windows. Windows
programmers eventually fix these and so we're gradually changing all the
relevent Modal dialogs to Modeless ones.
We maintain our own version of wv so we can update that as we please.
Welcome to AbiWord :-)
Cheers
Martin
On Sat, 22 Jul 2000, Goran Thyni wrote:
> Hi all,
>
> most of the coding part of a patch for using gnome-xml
> instead of expat when HAVE_GNOME is defined is ready.
>
> The main part is minimal, but there are lots of casts
> spread over the code base since XML_Char in expat is signed
> and xmlChar (thru #define XML_Char xmlChar) in gnome-xml is unsigned.
>
> The remaining problems is some diffences in handling of charsets (UTF-8)
> that currently breaks the statusbar init.
> I will look into that ASAP.
>
> My question is:
> 1. What should I do with the patch since it currently breaks the
> application?
> a/ submit it asis anyway.
> b/ change critical parts to be ifdef by f.ex. HAVE_GNOME_XML
> c/ submit to someone for review and discussion
> The policy question is: how much breakage is acceptable?
>
> 2. One function in wv uses expat, where do I send that patch?
>
> If someone want to have a look in the meantime, let me know, and I will
> send the patch.
>
> regards,
> Göran.
>
>
This archive was generated by hypermail 2b25 : Sat Jul 22 2000 - 03:05:27 CDT