Subject: RE: Big wv/LibOLE2 patch
From: James Montgomerie (jamie@montgomerie.net)
Date: Thu Jun 01 2000 - 18:02:45 CDT
> -----Original Message-----
> From: Martin Sevior
> Sent: 31 May 2000 01:59
>
> On Tue, 30 May 2000, James Montgomerie wrote:
> > I've finally managed to find some time to work on this, and
> > attached are two
> > patches (one for the abi tree, one for the wv tree) which implement the
> > LibOLE2/wv integration talked about a couple of months ago.
> >
>
> Unfortunately the abi.patch.gz file did not come through
> correctly. It decompresses to a file of 0 length. Can you resend
> abi.patch.gz. I'd like to try this on a killer word document I have. It
> crashes abiword and wv.com without fail.
Attached are two files (again), both containing something this time,
hopefully :-)
I'm pretty happy it's stable, and would even stick my neck out and say I
wouldn't mind if it was committed. Watch out for it not working on
opposite-endian machines (an easy fix if it doesn't), and GLIB not building
on non-Linux machines (which, thanks to Dom's readme, should also be an easy
fix for people on those platforms to do - just some #defines, if memory
serves).
I've attached both files because I've changed a few more things in the wv
tree in an attempt to fix bug 868
(http://www.abisource.com/bugzilla/show_bug.cgi?id=868).
The bug is now 'fixed', but in a rather kludgy way. I'm not quite sure
what's going on, but I think the importer was trying to find a non-existent
picture. I've put in some checks (line 572 of wvHtml.c and 272 of
ie_imp_MsWord.cpp), but they shouldn't be needed, as we should never get to
that point in a state where the checks fail. The checks won't make anything
that worked before fail, and they will make some things that didn't work
before work, but they're not the 'right' solution. If someone (Justin?) who
knows more about the file format could take a look at it, I'd be
appreciative. If not, I'll come back to it after I've got into the exporter
and know the file format a bit better. I've left the bug open, since the
fix doedn't fix the 'real' bug - I'll attach a note to it once the 'fix' is
committed.
Jamie.
This archive was generated by hypermail 2b25 : Thu Jun 01 2000 - 18:00:48 CDT