Subject: RE: commit - libole2 fixes
From: James Montgomerie (jamie@montgomerie.net)
Date: Fri Jun 09 2000 - 09:55:59 CDT
> -----Original Message-----
> From: Michael D. Pritchett [mailto:MPritchett@attglobal.net]
> To: James Montgomerie; Jeremy Sheeley; abiword-dev@abisource.com
> Subject: Re: commit - libole2 fixes
>
> > > Committing Jamie and Michael's libole fixes for compilation on Win32.
> > > Note that
> > > this simply typedef's off_t to a long on line 18. Is this the correct
> > > thing to
> > > do?
> >
> > Quite possibly not. Does it work? (Can you load Word files? :-)
> >
> > I'll look towards finding a more 'correct' solution over the weekend, if
> > no-one else gets there before me.
>
> I am looking forward to the 'correct' solution.
>
> The #defines and typedefs I inserted were not arbitrary. They were
> generally pulled out of the cygwin gcc include headers or were defined in
> MVC headers. I inserted them not to get a a quick and dirty build. Any
> help to get them right is appreciated.
Sorry - I wasn't trying to suggest that they were, my wording just went a
bit astray. A few people on the list had expressed worry that we might not
be doing the right thing here, what I meant to say was "I'll examine the
typedefs more over the weekend to ensure the solution we're using is
correct". Your way of finding the correct ones (looking in CygWin and MS
headers) was exactly what I was going to do to check correctness anyway, so
I guess they will be correct, and I'll leave them alone.
Jamie.
This archive was generated by hypermail 2b25 : Fri Jun 09 2000 - 09:54:12 CDT