Re: commit: Hack to remove final character dirt


Subject: Re: commit: Hack to remove final character dirt
From: Aaron Lehmann (aaronl@vitelus.com)
Date: Sun Jun 11 2000 - 11:04:51 CDT


If we could vote for who recieved the patch prize...

On Mon, 12 Jun 2000, Martin Sevior wrote:

>
> Committed a simple hack to shift text runs by one pixel relative to the
> text line they are on. This removes the last traces of character dirt that
> appears when deleting character with tails that descent to the bottom of
> a text cell. Like "g". See Aarons earlier email.
>
> The most relevent code is in...
>
> void fp_TextRun::_draw(dg_DrawArgs* pDA)
> {
> <snip>
> UT_sint32 yTopOfRun = pDA->yoff - m_iAscent-1; // Hack to remove
> UT_sint32 yTopOfSel = yTopOfRun+1; // final character dirt
>
>
> And a similar shift by one pixel in FieldRuns. I've tested this pretty
> thoroughly but of course Bob and Paul should torture the code to make sure
> this is all that is needed.
>
> Cheers
>
> Martin
>
>
>
>
>



This archive was generated by hypermail 2b25 : Sun Jun 11 2000 - 11:05:06 CDT