Patch

Subject: Patch
From: Mike Nordell (tamlin@algonet.se)
Date: Thu May 04 2000 - 21:58:02 CDT

• sorted by: [ date ] [ thread ] [ subject ] [ author ]
• Next message: Alan De Smet: "Building Win98"
• Previous message: Mike Nordell: "Bugs in 0.7.9"

First off, I'm sorry for not supplying 'diff -u' or what the preferred
format is. Please bare with me, I'm on a WinNT box.

---
af/ev/xp/ev_Menu_Layouts.cpp
EV_Menu_Layout::setLayoutItem should use DELETEP instead of FREEP when
deleting items contained in m_layoutTable.
I.e.
  FREEP(m_layoutTable[indexLayoutItem]);
should be
  DELETEP(m_layoutTable[indexLayoutItem]);
The same goes for the d'tor.
I'm a bit surprised no one had a crash from this.
---
af/xap/xp/xap_Frame.cpp
XAP_Frame d'tor calls
  UT_VECTOR_PURGEALL(char *,m_vecToolbarLayoutNames);
It should call
  UT_VECTOR_FREEALL
since the strings are allocated by UT_cloneString (i.e. calloc).
---
The same patch for the same reason should also be applied to
af/xap/xp/xap_Prefs.cpp, XAP_Prefs d'tor
for the line
  UT_VECTOR_PURGEALL(char *, m_vecRecent)
---
af/gr/win/gr_Win32Image.cpp
GR_Win32Image d'tor should 'free' instead of 'delete' it's member
'm_pDIB'.
---
/Mike

• Next message: Alan De Smet: "Building Win98"
• Previous message: Mike Nordell: "Bugs in 0.7.9"

This archive was generated by hypermail 2b25 : Thu May 04 2000 - 20:59:03 CDT