quick fix: Re: Serious bug in new linked lists

Subject: quick fix: Re: Serious bug in new linked lists
From: Mike Nordell (tamlin@algonet.se)
Date: Wed May 17 2000 - 17:33:24 CDT

Quick fix here (i hope). I'll look deeper into what I've destroyed ASAP.
I can't at the moment supply a patch (I have my local sources in a rather
messy state right now).

> Whenever you delete a blank line with text
> on the previous line, AbiWord asserts and then segfaults. To verify,
try
> the following steps:
>
> open abiword
> press space, enter, backspace
> - ->
> segfault

in src/text/fmt/xp/fl_BlockLayout.cpp
fl_BlockLayout::doclistener_deleteStrux()
around line 2473 there's a line

  UT_ASSERT(pRun);

That's the assert that triggers.

To (temporarily) fix you want to change 

---
   }

   UT_ASSERT(pRun);

   m_pFirstRun = pRun;

   // then link what's left
   m_pFirstRun->insertIntoRunListAfterThis(*pLastRun);
---
to
---
   m_pFirstRun = pRun;

   // then link what's left
   pLastRun->setNext(m_pFirstRun);

   if (m_pFirstRun)
   {
    m_pFirstRun->setPrev(pLastRun);
   }

---

I check into this matter ASAP.

/Mike

This archive was generated by hypermail 2b25 : Wed May 17 2000 - 16:34:04 CDT