Subject: Re: Commit: minor PS cleanup after Vlad's patch
From: Vlad Harchev (hvv@hippo.ru)
Date: Thu Nov 02 2000 - 01:44:38 CST
On Thu, 2 Nov 2000, Dom Lachowicz wrote:
> Yes, I kept the same semantics:
>
> _emit_setFont()
> {
> _emit_setFont(currentFont);
> [removed code to set font]
> }
>
> _emit_setFont(Font font)
> {
> [ps code to set font]
> }
>
> My problem was mainly with 1) code duplication and 2) the "CJK" tacked onto
> the function name when it was actually generic code that had nothing to do
> with CJK fonts. For example, I couldn't imagine some guy who implements
> Hebrew or Arabic next year would know to call emit_setFontCJK(). It wasn't
> anything serious and certanly wasn't anything to feel "stupid" about. I'm
> sorry if I sounded that way. I didn't mean to.
OK, thank you. As for me, I would have used then
_emit_setFont(Font* font_=NULL)
{
Font* font = font_ ? font_ : currentFont;
[do the rest with 'font']
}
and had only one function instead of two.
I'm sorry for such suspiction.
> Apologies,
> Dom
> _________________________________________________________________________
> Get Your Private, Free E-mail from MSN Hotmail at http://www.hotmail.com.
>
> Share information about yourself, create your own public profile at
> http://profiles.msn.com.
>
Best regards,
-Vlad
This archive was generated by hypermail 2b25 : Thu Nov 02 2000 - 02:02:32 CST