Subject: Re: WordCount dialog
From: Sam TH (sam@uchicago.edu)
Date: Fri Nov 10 2000 - 08:57:46 CST
On Fri, Nov 10, 2000 at 03:44:36PM +0100, Mike Nordell wrote:
> I was a bit confused at first when it only displayed the last two characters
> of the current document name in its caption/title. Then I had a look at
> AP_Dialog_WordCount::ConstructWindowName and realized that function
> deliberately sets the maximum title length to 26 chars.
>
> My question now becomes, how did this number turn up? Is it something that
> looks good in some X environment? Perhaps a more appropriate approach would
> be to have a pure virtual function in AP_Dialog_WordCount that gets the
> maximum number of "title displayable" characters for each platform? In Win32
> it only uses about 60% of the displayable area, unecessary truncating the
> document name (well, not really truncating, it chops of the _beginning_ of
> the document name).
>
Well, on my system, it doesn't have a title at all, but if I switch window
managers so that it has a title, then it it takes up almost no room.
As a general principle, hardcoded limits are evil, and should be removed.
Patches gladly accepted.
sam th
sam@uchicago.edu
http://www.abisource.com/~sam/
GnuPG Key:
http://www.abisource.com/~sam/key
This archive was generated by hypermail 2b25 : Fri Nov 10 2000 - 08:57:48 CST