Subject: Re: Commit: exporter work
From: Mike Nordell (tamlin@algonet.se)
Date: Thu Apr 12 2001 - 14:32:07 CDT
Andrew Dunbar wrote:
> - return c;
> + return reinterpret_cast<UT_Vector *>(c);
This is really, REALLY, dangerous and I _strongly_ advise against it.
> - virtual UT_Vector * suggestWord (const UT_UCSChar * word, size_t len);
> + virtual UT_Vector * suggestWord (UT_UCSChar * word, size_t len);
This change also seems unnecessary. Are we really to modify what "word"
points to in this function from now on? I think not, and the error is
elsewhere. I think this change isn't good.
> protected:
> - virtual bool requestDictionary (const char * szLang);
> + virtual bool requestDictionary (char * szLang);
This one _definitely_ is bad.
/Mike
This archive was generated by hypermail 2b25 : Thu Apr 12 2001 - 14:30:10 CDT