Subject: Re: BUG: handling italicized text
From: Dom Lachowicz (doml@appligent.com)
Date: Fri Dec 07 2001 - 13:23:33 CST
Umm... am I wrong here, or can you just do a FillRect with a larger
rectangle? I don't want a slanty/angled background just because my last
character is italic. The highlight color background should still be a
rectangle. You just have to figure out how much is in the overhang and
extend your fillrect by that much. MSWord does this. And you don't break
anyone's builds...
Dom
On Fri, 2001-12-07 at 14:17, Tomas Frydrych wrote:
>
> When a text run is italicized the overhanging part of the last
> character of that run gets chopped off. In the past this only
> happened on screen, but since we now support background
> colours different than white, it now happens also while printing; this
> makes it a very serious bug -- the printout looks really crappy.
>
> The flaw is in assuming in fp_TextRun::_draw that each run and
> any of its parts is contained in a rectangular region, which is not
> true for italicized text. In order to fix this bug, we will have to
> replace the _fillRect calls with _fillRegion call -- this will require new
> pure virtual fillRegion in GR_Graphics class, plus some additional
> changes to the xp font handling, so that the text run can determine
> the overhang of text in italics.
>
> I will try to implement the xp stuff and the win32 and gtk versions of
> the pure virtuals over the weekend, and this is an advanced warning
> that the changes will break all other platforms.
>
> Tomas
>
This archive was generated by hypermail 2b25 : Fri Dec 07 2001 - 13:31:51 CST