Subject: Re: Optimization Opportunities 1 [long]
From: Sam TH (sam@uchicago.edu)
Date: Mon Feb 05 2001 - 11:01:42 CST
On Mon, Feb 05, 2001 at 05:38:22PM +0100, Mike Nordell wrote:
> Sam TH wrote:
> >> The fread() is a potentially very costly operation. Do "we" control the
> >> FILE*? [...]
> >
> >In what sense do you mean "own"?
>
> Do we, Abi code, open (fopen() ) that file stream.
Yes.
>
> >Those sound like good ideas. Feel free to check them in, or just to
> >provide a patch if you want me to profile again.
>
> My changes would not affect coverage figures. Since I don't do Unix
> currently´, and even that I do know how to make these changes I currently
> won't (so call me stubborn :-) ). At least not until performance figures
> have been displayed. Should anyone Unix see the need to fix this, you all
> know what to alias by using a ptr or ref. from my earlier post.
>
I thought that code was used on all the platforms? How does Win32 do
spell checking?
> > I thought those numbers were weird too. But they are what gcov gave
> > me when I ran it. Maybe later I'll create a new run, and see if I
> > still get weird data. But it would be nice to see what you find.
>
> Well, I don't have access to any coverage analyzer, but I sure have access
> to a performance analyzer that rocks. :-)
> OK, I'll do an (somewhat) optimized build and see how this turns out (though
> it will not be 100% accurate since I have to turn off some flags to get
> somewhat real figures). I can't promise anything, but I hope it will be
> within the next day or two. If it appears I forgotten it, please remind me
> since I have a s**t-load of other stuff to do also (but I don't want this
> one to just be forgotten, so I really like to be remonded in case it seems I
> have forgotten it).
>
Ok, cool.
> [rewriting EV_UnixMenu::synthesizeMenu]
> > Could this be a POW?
>
> I think we all have more stuff that's more pressing atm, but I'd add it
> pretty high in the TODO files. Unless (!) someone lurking feel they want to
> try something. This is reasonably easy and would put your name in the
> CONTRIB file. :-) Anyone want to do this? (pleeease!)
>
> Anyway, I think it should be added to the TODO. Could you add it Sam?
>
Well, right now those todo files are just autogenerated from the
code. I think we should start a real TODO file, in which we can put
ideas. This sounds like a good first one.
> > Can you commit [...] My tree doesn't have Makefiles any more :-)
>
> Done, and (according to my own complaint) I'll also post a commit message.
>
> > Also, optimized builds start too fast. :-)
>
> Well, isn't this perhaps a place of "premature optimization"? (OK, I don't
> know at all what monster of a machine you run :-) ).
Well, my machine isn't all that great, but I know Abi should start
faster on slow machines than it does now. And like I said, faster
than VI. :-)
sam th
sam@uchicago.edu
http://www.abisource.com/~sam/
GnuPG Key:
http://www.abisource.com/~sam/key
This archive was generated by hypermail 2b25 : Mon Feb 05 2001 - 11:01:20 CST