Subject: Re: PATCH -- quiet libtool builds
From: Sam TH (sam@uchicago.edu)
Date: Thu Feb 15 2001 - 19:11:28 CST
On Thu, Feb 15, 2001 at 05:01:19PM -0800, Paul Rohr wrote:
> FYI. As strong as my preference for silent libtool builds is, I decided not
> to just go ahead and commit the following hack for three reasons:
>
> 1. The upstream maintainers might not want it.
> 2. Frodo's stuff uses automake, which would clobber this.
> 3. This probably should be an option which defaults to off.
>
> Still, I find it quite useful for isolating those pesky signed/unsigned
> warnings. Feel free to use, improve, commit, and/or ignore as you see fit.
> :-)
>
Well, I haven't actually applied these patches, or tested them, but I
have some comments anyway.
First, does this still print the filename?
>
>
> Index: expat/lib/Makefile.in
> ===================================================================
> RCS file: /cvsroot/expat/lib/Makefile.in,v
> retrieving revision 1.2
> diff -u -r1.2 Makefile.in
> --- expat/lib/Makefile.in 2001/02/07 04:48:34 1.2
> +++ expat/lib/Makefile.in 2001/02/15 23:51:21
> @@ -56,7 +56,8 @@
> AS = @AS@
> CC = @CC@
> DLLTOOL = @DLLTOOL@
> -LIBTOOL = @LIBTOOL@
> +noisy_LIBTOOL = @LIBTOOL@
> +LIBTOOL = @$(noisy_LIBTOOL) --silent
> LN_S = @LN_S@
> OBJDUMP = @OBJDUMP@
> PACKAGE = @PACKAGE@
I really think the better change is to do this:
LIBTOOL= @LIBTOOL@ --silent
and then in the .c.lo rule:
.c.lo:
$(LTCOMPILE) -c $<
change this to
.c.lo:
@$(LTCOMPILE) -c $<
@echo $<
Note that this is also totally untested.
> Index: psiconv/compat/Makefile.in
> ===================================================================
> RCS file: /cvsroot/psiconv/compat/Makefile.in,v
> retrieving revision 1.5
> diff -u -r1.5 Makefile.in
> --- psiconv/compat/Makefile.in 2001/02/15 01:48:42 1.5
> +++ psiconv/compat/Makefile.in 2001/02/16 00:00:53
> @@ -65,7 +65,8 @@
> INT_16_BIT = @INT_16_BIT@
> INT_32_BIT = @INT_32_BIT@
> INT_8_BIT = @INT_8_BIT@
> -LIBTOOL = @LIBTOOL@
> +noisy_LIBTOOL = @LIBTOOL@
> +LIBTOOL = @$(noisy_LIBTOOL) --silent
> LN_S = @LN_S@
> MAKEINFO = @MAKEINFO@
> OBJDUMP = @OBJDUMP@
> Index: psiconv/Makefile.in
> ===================================================================
> RCS file: /cvsroot/psiconv/psiconv/Makefile.in,v
> retrieving revision 1.4
> diff -u -r1.4 Makefile.in
> --- psiconv/psiconv/Makefile.in 2001/02/15 01:48:43 1.4
> +++ psiconv/psiconv/Makefile.in 2001/02/16 00:00:55
> @@ -65,7 +65,8 @@
> INT_16_BIT = @INT_16_BIT@
> INT_32_BIT = @INT_32_BIT@
> INT_8_BIT = @INT_8_BIT@
> -LIBTOOL = @LIBTOOL@
> +noisy_LIBTOOL = @LIBTOOL@
> +LIBTOOL = @$(noisy_LIBTOOL) --silent
> LN_S = @LN_S@
> MAKEINFO = @MAKEINFO@
> OBJDUMP = @OBJDUMP@
You should just make these changes in the Makefile.am for psiconv.
Just adding
noisy_LIBTOOL = @LIBTOOL@
LIBTOOL = @$(noisy_LIBTOOL) --silent
to Makefile.am should do the trick. You do need to have automake to
do this, but I hope you can manage that (it only depends on perl).
I can't think of anything else at the moment.
sam th
sam@uchicago.edu
http://www.abisource.com/~sam/
GnuPG Key:
http://www.abisource.com/~sam/key
This archive was generated by hypermail 2b25 : Thu Feb 15 2001 - 19:09:20 CST