Subject: [RFC] commit -- fixed crash on splash screen loading
From: Sam TH (sam@uchicago.edu)
Date: Mon Feb 26 2001 - 23:25:31 CST
Currently, is the current directory on unix has a file called
splash.png, we use that as the splash screen. This commit fixes the
bug that if it wasn't a real PNG, we were crashing (since we weren't
checking the return code from UT_PNG_getWhatever()).
But the real question is, does this feature have any point at all?
Sure, you would have to recompile to see a new splash screen, but I
doubt many people knew this "feature" existed anyway. I know I
didn't.
I see two options:
1. Remove this feature. [+1 from me]
2. Rename the necessary file to something like
"PleaseAbiReallyShowThis.png"
Option 3, using whatever "splash.png' is in the current directory the
way we do now, is unacceptably broken, IMNSHO.
Comments?
Fixed crash when attempting to load bad PNG. Return values are there
for a reason. :-)
CVS: ----------------------------------------------------------------------
CVS: Enter Log. Lines beginning with `CVS:' are removed automatically
CVS:
CVS: Committing in .
CVS:
CVS: Modified Files:
CVS: ap_UnixApp.cpp
CVS: ----------------------------------------------------------------------
sam th
sam@uchicago.edu
http://www.abisource.com/~sam/
GnuPG Key:
http://www.abisource.com/~sam/key
This archive was generated by hypermail 2b25 : Mon Feb 26 2001 - 23:21:42 CST